UPSTREAM: <carry>: support feature gate filtering from upstream #2310
Conversation
openshift-ci-robot
added
the
backports/unvalidated-commits
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
@stbenjam: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stbenjam The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@stbenjam: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview origin/pull#29837 |
|
@stbenjam: An error was encountered. No known errors were detected, please see the full error message for details. Full error message.
unable to get pr from github for: origin/pull#29837: Get "http://ghproxy/repos/origin/pull/pulls/29837": failed to get installation id for org origin: the github app is not installed in organization origin
Please contact an administrator to resolve this issue. |
|
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn origin/pull#29837 |
|
@stbenjam: An error was encountered. No known errors were detected, please see the full error message for details. Full error message.
unable to get pr from github for: origin/pull#29837: Get "http://ghproxy/repos/origin/pull/pulls/29837": failed to get installation id for org origin: the github app is not installed in organization origin
Please contact an administrator to resolve this issue. |
|
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn openshift/origin#29837 |
|
@stbenjam: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a5238290-3665-11f0-9423-47e5a5f1b3c7-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview openshift/origin#29837 |
|
@stbenjam: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a8b49890-3665-11f0-841c-bc234f3dfb38-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial openshift/origin#29837 |
|
@stbenjam: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/15120af0-370a-11f0-91e1-0a72cb4275f5-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-serial openshift/origin#29837 |
|
@stbenjam: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1d263810-370a-11f0-94bb-2354090009ae-0 |
|
@stbenjam: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@stbenjam: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial openshift/origin#29837 |
|
@stbenjam: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cfd5f2b0-3bc0-11f0-924b-46625cc1174a-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-serial openshift/origin#29837 |
|
@stbenjam: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d6c241a0-3bc0-11f0-9346-379432385884-0 |
|
@stbenjam: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@stbenjam: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@stbenjam: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
When considering upstream feature gates, not all are known or present in
openshift/api, so we have to be selective about which we filter on.
This uses data provided by OTE and an allow list to include/exclude
upstream tests.
$ k8s-tests-ext list tests --platform aws --feature-gate VolumeAttributesClass |\
jq '.[].name' | grep VolumeAttributesClass | wc -l
30
$ k8s-tests-ext list tests --platform aws |\
jq '.[].name' | grep VolumeAttributesClass | wc -l
0
|
@stbenjam: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
Re-opening with a clean PR |
When considering upstream feature gates, not all are known or present in
openshift/api, so we have to be selective about which we filter on.
This uses data provided by OTE and an allow list to include/exclude
upstream tests.
$ k8s-tests-ext list tests --platform aws --feature-gate VolumeAttributesClass |
jq '.[].name' | grep VolumeAttributesClass | wc -l
30
$ k8s-tests-ext list tests --platform aws |
jq '.[].name' | grep VolumeAttributesClass | wc -l
0